Skip to content

Preseve session ID via the ID token - #44

Draft
gklei wants to merge 2 commits into
persist-id-tokenfrom
preserve_session_via_id_token
Draft

Preseve session ID via the ID token#44
gklei wants to merge 2 commits into
persist-id-tokenfrom
preserve_session_via_id_token

Conversation

@gklei

@gklei gklei commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Sends the ID token with the refresh request so it can be used to validate the authenticated fulcra_session_id, and attach it to the new access and ID tokens after refresh.

@gklei gklei changed the title WIP: Preserve session via id_token Preserve session via id_token Jun 17, 2026
@gklei
gklei marked this pull request as ready for review June 17, 2026 21:33
@gklei
gklei requested a review from kaiju June 17, 2026 21:34
@kaiju

kaiju commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Fun question: What happens when we need to refresh the ID token?

@lancelets lancelets self-assigned this Jun 23, 2026
@lancelets

Copy link
Copy Markdown
Contributor

Fun question: What happens when we need to refresh the ID token?

@gklei and I tried changing the ID token expiration time to be relatively long (currently 30 days) and setting a maximum refresh token expiration to match. I think we could set that to a very long time if we want them to effectively not expire.

I also like your idea of using ignoreExpiration: true when verifying the ID token in the refresh flow. That would allow us to use the ID token for more normal purposes with a normal lifespan if we want to at some point. I'll plan on adding that and reverting the expiration changes, unless a long ID token expiration time sounds better than accepting an expired ID token—I'm going in circles about the trade-offs.

@lancelets lancelets changed the title Preserve session via id_token Persist ID token in FulcraCredentials Jul 27, 2026
@lancelets lancelets changed the title Persist ID token in FulcraCredentials Preseve session ID via the ID token Jul 27, 2026
@lancelets
lancelets marked this pull request as draft July 27, 2026 22:13
@lancelets
lancelets changed the base branch from main to persist-id-token July 27, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants